Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated various versions to fix some transitive CG issues #239

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

marcpopMSFT
Copy link
Member

No description provided.

@marcpopMSFT
Copy link
Member Author

@baronfel I'm sort of blindly updating all of the packages in this project as CG is flagging a transitive dependency and it's unclear which one. When I updated S.CL, I got some build failures but I couldn't find guidance on how to solve them. Suggestions?

C:\repos\cli-lab\src\dotnet-core-uninstall\Shared\Commands\UninstallHelpBuilder.cs(14,36): error CS0246: The type or namespace name 'ICommand' could not be found (are you missing a using directive or an assembly reference?) [C:\repos\cli-lab\src\dotnet-core-uninstall\dotnet-core-uni
nstall.csproj]

@baronfel
Copy link
Member

baronfel commented Oct 5, 2022

This is going to be a whole thing - you're hitting all of the beta3 and beta4 changes at once here. The error you're seeing comes from changes to the HelpBuilder, but after you fix that all of the Option/Argument changes flow to the surface.

@marcpopMSFT
Copy link
Member Author

So looks like the build is still failing but this time on the Azure upgrade. I'm not sure if there is guidance on how to fix those out there somewhere.

@marcpopMSFT
Copy link
Member Author

@baronfel I got a bit further on this. I removed the azure blob component that was old and breaking the build as it appears it was just added here because it was copied over from installer. I also noticed that CommandLineParseResult was reporting an error because the environment command line args was including the path to the dll itself.

At this point, I'm not sure what to investigate next. I see that it returns a CommandLineConfigs object and calls invoke but I don't see what's getting invoked. I set a breakpoint in ListCommandExec.cs but it's not getting there (this is with a simple list call). At this point, I think it's the S.CL invocation that's off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants